Update Windows process-tree tests for inherited FDs - #34640
Merged
copyberry[bot] merged 1 commit intoJul 21, 2026
Merged
Conversation
## Why The PTY and pipe spawn helpers now require callers to specify which file descriptors should be inherited, following #13644. ## What changed Pass empty inherited-FD slices from the Windows process-tree tests, which do not need to preserve any file descriptors. GitOrigin-RevId: 5e578df34e195251490608a163f8aaee0a6e681c
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/5e578df34e195251490608a163f8aaee0a6e681c
branch
from
July 21, 2026 23:30
68011c4 to
bdd3118
Compare
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/5e578df34e195251490608a163f8aaee0a6e681c
branch
July 21, 2026 23:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update Windows process-tree tests for inherited FDs
Why
The PTY and pipe spawn helpers now require callers to specify which file
descriptors should be inherited, following
#13644.
What changed
Pass empty inherited-FD slices from the Windows process-tree tests, which do
not need to preserve any file descriptors.