Simplify TUI restoration for the external editor - #34551
Merged
copyberry[bot] merged 1 commit intoJul 21, 2026
Merged
Conversation
## What changed Remove the unused `RestoreMode` selection from `Tui::with_restored`. The helper now always restores the terminal while keeping raw mode enabled, matching its external-editor call site. GitOrigin-RevId: b820aaaa933d7354d2a21b95900b059b3e8e2ac6
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/b820aaaa933d7354d2a21b95900b059b3e8e2ac6
branch
from
July 21, 2026 14:17
f6b7286 to
b5b8a63
Compare
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/b820aaaa933d7354d2a21b95900b059b3e8e2ac6
branch
July 21, 2026 14:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplify TUI restoration for the external editor
What changed
Remove the unused
RestoreModeselection fromTui::with_restored. The helpernow always restores the terminal while keeping raw mode enabled, matching its
external-editor call site.