Avoid buffering replay-irrelevant thread notifications - #34222
Merged
copyberry[bot] merged 1 commit intoJul 19, 2026
Merged
Conversation
## Why Raw response items, realtime audio, and other notifications that the TUI does not consume during replay can carry large payloads. Retaining them in each thread's replay buffer wastes memory and can evict useful buffered events. ## What changed - Skip replay buffering for notification types that are handled before routing or ignored during replay, while still updating turn and approval state. - Borrow notifications when recording events for an active thread so routing does not require an extra clone. ## Testing Add coverage that repeatedly sends large MCP progress and realtime audio notifications and verifies that the replay buffer, pending approval, and active turn state remain intact. GitOrigin-RevId: 5b3414f1db7f3ae1feea4fe6c0275e4a7a1a4174
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/5b3414f1db7f3ae1feea4fe6c0275e4a7a1a4174
branch
from
July 19, 2026 20:13
4187d7a to
d0516cf
Compare
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/5b3414f1db7f3ae1feea4fe6c0275e4a7a1a4174
branch
July 19, 2026 20:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid buffering replay-irrelevant thread notifications
Why
Raw response items, realtime audio, and other notifications that the TUI does
not consume during replay can carry large payloads. Retaining them in each
thread's replay buffer wastes memory and can evict useful buffered events.
What changed
or ignored during replay, while still updating turn and approval state.
does not require an extra clone.
Testing
Add coverage that repeatedly sends large MCP progress and realtime audio
notifications and verifies that the replay buffer, pending approval, and active
turn state remain intact.