Disambiguate skill mentions from shell parameters - #33232
Merged
copyberry[bot] merged 1 commit intoJul 15, 2026
Merged
Conversation
## Why Skill mentions and shell parameters both use a `$` prefix. Numeric and special shell parameters should not open or displace completion popups, while loaded skills can legitimately have digit- or hyphen-leading names. ## What changed - Classify `$` queries as skill candidates, shell variables, definite shell parameters, or ambiguous shell-like names. - Offer completion for an ambiguous name only when it fuzzy-matches a bindable loaded mention, reusing the filtered catalog when the popup opens. - Keep definite shell forms such as `$1`, `$12`, `$-`, and `$_` out of mention completion and preserve completion targets elsewhere in the composer. ## Testing Added unit and snapshot coverage for positional and special parameters, digit- and hyphen-leading skills, uppercase shell variables, unbindable qualified skills, and competing completion targets. GitOrigin-RevId: 8bb64cb5ca0fa8233c7fadb11a53678d57eb814c
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/8bb64cb5ca0fa8233c7fadb11a53678d57eb814c
branch
from
July 15, 2026 04:04
3f8635e to
b6f1cfa
Compare
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/8bb64cb5ca0fa8233c7fadb11a53678d57eb814c
branch
July 15, 2026 04:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disambiguate skill mentions from shell parameters
Why
Skill mentions and shell parameters both use a
$prefix. Numeric and specialshell parameters should not open or displace completion popups, while loaded
skills can legitimately have digit- or hyphen-leading names.
What changed
$queries as skill candidates, shell variables, definite shellparameters, or ambiguous shell-like names.
loaded mention, reusing the filtered catalog when the popup opens.
$1,$12,$-, and$_out of mentioncompletion and preserve completion targets elsewhere in the composer.
Testing
Added unit and snapshot coverage for positional and special parameters,
digit- and hyphen-leading skills, uppercase shell variables, unbindable
qualified skills, and competing completion targets.