Reap exited PID-managed app-server children - #32838
Merged
copyberry[bot] merged 1 commit intoJul 13, 2026
Merged
Conversation
## Why An app-server child started by a previous updater can remain as a zombie after termination. Its PID then still appears active, causing daemon shutdown to wait until its timeout instead of removing the stale PID file. ## What changed - Poll `waitpid` with `WNOHANG` while waiting for a PID-managed process to stop. - Check process state before enforcing the stop deadline so an exit at the deadline can still be observed and cleaned up. ## Testing Added a regression test that stops an untracked child and verifies that shutdown finishes promptly and removes its PID file. GitOrigin-RevId: b203cf860e4207716a6cfc36015f8ee77918d13a
Contributor
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/b203cf860e4207716a6cfc36015f8ee77918d13a
branch
from
July 13, 2026 17:34
12f88d5 to
b36c0b1
Compare
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/b203cf860e4207716a6cfc36015f8ee77918d13a
branch
July 13, 2026 17:35
jasonbuchanantech-hash
temporarily deployed
to
issue-triage
July 13, 2026 17:46 — with
GitHub Actions
Inactive
jasonbuchanantech-hash
temporarily deployed
to
issue-triage
July 13, 2026 17:46 — with
GitHub Actions
Inactive
jasonbuchanantech-hash
temporarily deployed
to
issue-triage
July 13, 2026 17:46 — with
GitHub Actions
Inactive
selbstlesebuch
temporarily deployed
to
issue-triage
July 13, 2026 17:51 — with
GitHub Actions
Inactive
selbstlesebuch
temporarily deployed
to
issue-triage
July 13, 2026 17:51 — with
GitHub Actions
Inactive
selbstlesebuch
temporarily deployed
to
issue-triage
July 13, 2026 17:51 — with
GitHub Actions
Inactive
selbstlesebuch
temporarily deployed
to
issue-triage
July 13, 2026 17:52 — with
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reap exited PID-managed app-server children
Why
An app-server child started by a previous updater can remain as a zombie after
termination. Its PID then still appears active, causing daemon shutdown to wait
until its timeout instead of removing the stale PID file.
What changed
waitpidwithWNOHANGwhile waiting for a PID-managed process to stop.deadline can still be observed and cleaned up.
Testing
Added a regression test that stops an untracked child and verifies that shutdown
finishes promptly and removes its PID file.