Skip to content

Reap exited PID-managed app-server children - #32838

Merged
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/b203cf860e4207716a6cfc36015f8ee77918d13a
Jul 13, 2026
Merged

Reap exited PID-managed app-server children#32838
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/b203cf860e4207716a6cfc36015f8ee77918d13a

Conversation

@copyberry

@copyberry copyberry Bot commented Jul 13, 2026

Copy link
Copy Markdown

Reap exited PID-managed app-server children

Why

An app-server child started by a previous updater can remain as a zombie after
termination. Its PID then still appears active, causing daemon shutdown to wait
until its timeout instead of removing the stale PID file.

What changed

  • Poll waitpid with WNOHANG while waiting for a PID-managed process to stop.
  • Check process state before enforcing the stop deadline so an exit at the
    deadline can still be observed and cleaned up.

Testing

Added a regression test that stops an untracked child and verifies that shutdown
finishes promptly and removes its PID file.

## Why

An app-server child started by a previous updater can remain as a zombie after
termination. Its PID then still appears active, causing daemon shutdown to wait
until its timeout instead of removing the stale PID file.

## What changed

- Poll `waitpid` with `WNOHANG` while waiting for a PID-managed process to stop.
- Check process state before enforcing the stop deadline so an exit at the
  deadline can still be observed and cleaned up.

## Testing

Added a regression test that stops an untracked child and verifies that shutdown
finishes promptly and removes its PID file.

GitOrigin-RevId: b203cf860e4207716a6cfc36015f8ee77918d13a
@github-actions

Copy link
Copy Markdown
Contributor


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@copyberry
copyberry Bot force-pushed the copyberry/codex-internal-to-codex-oss/b203cf860e4207716a6cfc36015f8ee77918d13a branch from 12f88d5 to b36c0b1 Compare July 13, 2026 17:34
@copyberry
copyberry Bot merged commit b36c0b1 into main Jul 13, 2026
13 of 32 checks passed
@copyberry
copyberry Bot deleted the copyberry/codex-internal-to-codex-oss/b203cf860e4207716a6cfc36015f8ee77918d13a branch July 13, 2026 17:35
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 13, 2026
@scf4
scf4 temporarily deployed to issue-triage July 13, 2026 17:48 — with GitHub Actions Inactive
@scf4
scf4 temporarily deployed to issue-triage July 13, 2026 17:48 — with GitHub Actions Inactive
@scf4
scf4 temporarily deployed to issue-triage July 13, 2026 17:48 — with GitHub Actions Inactive
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

6 participants