Stop persisting RMCP service traces - #31789
Merged
Merged
Conversation
felixxia-oai
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The SQLite feedback log enables TRACE by default.
rmcp::servicerenders complete MCP service events at TRACE, including large tool catalogs and other protocol payloads. In a busy local sample, this was the largest retained source and individual rows reached about 2 MiB.These rows can quickly consume the per-thread retention budget, displace smaller diagnostics, and add unnecessary SQLite insert-and-prune work.
What changed
rmcp::serviceat INFO and above in the SQLite feedback log.This is intentionally target-specific. Broader persistent-log policy changes can remain separate.
Related to #28224.