Conversation
richardopenai
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
fragmented_writes_yield_to_keepalive_and_queued_pongdeliberately blocks WebSocket writes while exercising keepalive and queued-Pong scheduling. It previously advanced those states with wall-clock sleeps. Under a sufficiently delayed CI worker, those sleeps and scheduling gaps could consume the test-only 100 ms Pong-watchdog budget, causing the relay to exit and the next write-permit send to fail withTrySendError::Disconnected.The failure was therefore a timing flake in the harness test, not evidence that the production relay mishandled a Pong.
What changed
test-utilfeature only forcodex-exec-serverdev dependencies.No production code or timeout values change.
Review guide
The behavioral change is confined to
noise_relay/harness_tests.rs; theCargo.tomlchange only exposes Tokio's paused-clock test APIs.Validation
just test -p codex-exec-server fragmented_writes_yield_to_keepalive_and_queued_pongjust fix -p codex-exec-serverjust bazel-lock-update(no lockfile changes)