Skip to content

[codex] Read buffering metadata from response events - #31064

Merged
fc-oai merged 2 commits into
mainfrom
fc/response-buffering-metadata
Jul 5, 2026
Merged

[codex] Read buffering metadata from response events#31064
fc-oai merged 2 commits into
mainfrom
fc/response-buffering-metadata

Conversation

@fc-oai

@fc-oai fc-oai commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Summary

  • read optional faster-model metadata from streamed buffering payloads
  • use the buffering payload itself to determine whether buffering UI should be shown
  • retain the existing header value as a compatibility fallback when the payload omits the field

Behavior

An object-valued buffering signal now enables the buffering UI. The response event's faster-model field takes precedence when present, while omitted fields fall back to existing response metadata. An explicit null leaves the retry target unset.

Validation

  • just test -p codex-api
  • just fix -p codex-api
  • cargo fmt --all -- --check
  • git diff --check
@fc-oai
fc-oai marked this pull request as ready for review July 3, 2026 23:32
@fc-oai
fc-oai requested a review from a team as a code owner July 3, 2026 23:32
@fc-oai

fc-oai commented Jul 4, 2026

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown
Contributor

Codex Review: Didn't find any major issues. 🎉

Reviewed commit: 21f9e15805

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@fc-oai
fc-oai enabled auto-merge (squash) July 4, 2026 23:58
@fc-oai
fc-oai merged commit be33f80 into main Jul 5, 2026
35 checks passed
@fc-oai
fc-oai deleted the fc/response-buffering-metadata branch July 5, 2026 00:07
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 5, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

2 participants