Handle mixed-case URLs in Windows command safety - #30879
Merged
Merged
Conversation
charliemarsh-oai
added
bug
charliemarsh-oai
marked this pull request as ready for review
July 2, 2026 00:22
This was referenced Jul 2, 2026
charliemarsh-oai
force-pushed
the
charlie/fix-windows-url-case-sensitivity
branch
from
July 6, 2026 11:46
d546400 to
fc3bcca
Compare
iceweasel-oai
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Start-ProcessinvocationsWhy
PowerShell and URL parsing treat schemes case-insensitively, but the pre-parser only searched for lowercase
http://andhttps://. When a URL appeared in the same shlex token as surrounding PowerShell syntax, such asStart-Process('HTTPS://example.com');, the prefix was not stripped and the command was incorrectly classified as not dangerous.Validated with the scoped
codex-shell-commandsuite (138 tests) and a direct classifier reproduction that failed before the change and passed afterward.