[codex-cli] Show reset details in redemption picker - #30488
Merged
Conversation
jayp-oai
changed the title
jayp-oai
force-pushed
the
codex/reset-credit-picker
branch
from
July 4, 2026 00:38
9b5fa43 to
852973c
Compare
This was referenced Jul 4, 2026
jayp-oai
marked this pull request as ready for review
July 6, 2026 18:33
fcoury-oai
approved these changes
Jul 6, 2026
fcoury-oai
left a comment
fcoury-oai
left a comment
Contributor
There was a problem hiding this comment.
I wasn't able to run a smoke test on this one since I don't have any resets. Code looks good and the proposed user interface does as wlel.
jayp-oai
added a commit
that referenced
this pull request
Jul 6, 2026
## Why Supported clients currently receive only a reset-credit count from `account/rateLimits/read`. The redemption UI and other app-server clients need each available credit's expiry and ID so they can explain what will expire and consume the credit a user selected. This information belongs on the existing rate-limit read surface rather than a second app-server list RPC that clients would need to coordinate. ## What changed - extend `rateLimitResetCredits` on `account/rateLimits/read` with nullable `credits` detail rows - fetch usage and reset-credit details concurrently; if the detail request fails, times out, or cannot be parsed, preserve the usage response and return `credits: null` - expose each credit's ID, reset type, status, grant time, expiry time, title, and description - add an optional nullable `creditId` to `account/rateLimitResetCredit/consume`; omitting it preserves the existing automatic-selection behavior - forward a selected credit ID to the Codex backend and update the app-server documentation and generated schemas The TUI consumer is stacked in #30488. ## Validation - `just test -p codex-app-server-protocol` (251 passed) - `just test -p codex-backend-client` (16 passed) - `just test -p codex-app-server rate_limit` (18 passed) Part of #29618.
jayp-oai
force-pushed
the
codex/reset-credit-picker
branch
from
July 6, 2026 22:59
e0ab6a2 to
5527081
Compare
jayp-oai
force-pushed
the
codex/reset-credit-picker
branch
from
July 7, 2026 04:09
5527081 to
6a9c841
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Users can see that usage-limit reset credits are available, but not which credits they have, when each one expires, or which credit will be consumed. The TUI should use the supported rate-limit RPC for that information without maintaining a second reset-credit request path.
What changed
account/rateLimits/readrefresh when the user opens Redeem usage limit resetTUI preview
Rendered from the final standard-width and narrow
instasnapshots in this PR.Validation
just test -p codex-tui chatwidget::tests::usage(32 passed)just fix -p codex-tuiinstasnapshotsUses the reset-credit details added by #30395.
Fixes #29618.