[codex-rs] Add writes app approval mode - #30482
Merged
Merged
Conversation
zamoshchin-openai
marked this pull request as ready for review
June 28, 2026 21:10
This was referenced Jun 29, 2026
winston-openai
approved these changes
Jul 6, 2026
viyatb-oai
approved these changes
Jul 6, 2026
dylan-hurd-oai
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
writestoAppToolApprovaland exposes it through config and app-server schemas, including[apps._default].default_tools_approval_mode.writes, tools withreadOnlyHint = trueskip approval; all other tools prompt, including non-destructive writes and tools without annotations.Why
autoonly prompts for risk-hinted actions, whilepromptalso interrupts reads. Apps need a middle mode that gates writes without prompting for declared read-only actions.Validation
just write-config-schemajust write-app-server-schemajust fmtjust test -p codex-core mcp_turn_metadata(4 passed)just test -p codex-core writes_mode(2 passed)just test -p codex-app-server config_read_includes_apps(1 passed)just test -p codex-app-server-protocol(251 passed)just test -p codex-config(200 passed)just test -p codex-cli(300 passed)just fix -p codex-core -p codex-config -p codex-app-server-protocol -p codex-app-server -p codex-cli