Expose MCP app identity in app context - #29934
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
ee40dac to
822163b
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ee40dac10e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| pub connector_id: String, | ||
| pub link_id: Option<String>, | ||
| pub resource_uri: Option<String>, | ||
| pub app_name: Option<String>, |
There was a problem hiding this comment.
nit: just name since everything in this payload already refers to an app? or display_name?
There was a problem hiding this comment.
The consuming backend has it as app_name + we have action name passed here as well. app_name makes it more clear here i think
martinauyeung-oai
changed the title
3 participants
Why
MCP tool-call events need to expose trusted app identity and action metadata directly so v2 clients do not have to infer it from tool names or resource URIs.
What changed
appName,templateId, andactionNamefields to MCP tool-callappContext.appNameandtemplateIdfrom trusted Codex Apps metadata, and deriveactionNamefrom the trusted app resource metadata.appContextfields incodex-rs/app-server/README.md.Validation
just test -p codex-app-server-protocol mcp_tool_calljust test -p codex-core mcp_tool_call_item_metadata_only_trusts_codex_apps_identity mcp_tool_call_item_includes_app_identityjust write-app-server-schema