Decouple plugin manifest path resolution - #29620
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 01b4840b95
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
anp-oai
reviewed
Jun 23, 2026
anp-oai
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Plugin manifests use the same schema whether the package lives on the host or in an executor. Only the path representation differs: host callers need native
Pathinputs andAbsolutePathBufoutputs, while executor callers needPathUrithroughout.Maintaining separate parsing or resolver implementations would duplicate the manifest rules and allow them to drift. This PR instead makes URI-native resolution the single parsing path and keeps host conversion at the boundary.
What changed
parse_plugin_manifest_urithe shared manifest parser and resolve every path-bearing field asPathUri.PathUri, run the shared parser, then map resources back toAbsolutePathBuf.PluginManifest::try_map_resourcesso callers can convert the generic resource type without duplicating manifest construction./remains unsafe for every convention.Existing host manifest behavior is preserved; #28918 is the first executor consumer.
Verification
just test -p codex-utils-path-urijust test -p codex-pluginjust test -p codex-core-pluginsStack
PathUricontainment.