Add MCP tool call error metrics - #28976
Merged
Merged
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6d6030bc76
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
mzeng-openai
approved these changes
Jun 22, 2026
stevenlee-oai
force-pushed
the
dev/stevenlee/mcp-error-metrics
branch
from
June 22, 2026 23:45
6d6030b to
4ea51e4
Compare
stevenlee-oai
enabled auto-merge (squash)
June 22, 2026 23:48
stevenlee-oai
force-pushed
the
dev/stevenlee/mcp-error-metrics
branch
from
June 23, 2026 00:26
4ea51e4 to
ee04aec
Compare
anp-oai
reviewed
Jun 23, 2026
stevenlee-oai
force-pushed
the
dev/stevenlee/mcp-error-metrics
branch
from
June 23, 2026 05:13
d839bf5 to
cfd175c
Compare
anp-oai
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Codex Thread 019edc37-5345-7272-92c9-bf5494cf3819
Summary
CallToolResult.isErrorresponses as failed calls instead of successful transport-level callscodex.mcp.call.errorwith boundederror_typeand trusted plugin-serviceerror_codedimensionsScope
mcp_request; separating connection, timeout, protocol, and JSON-RPC failures requires preserving typed errors through the existing flattened error boundaryTesting
just test -p codex-core 'mcp_tool_call::tests::'(75 passed)just fix -p codex-corejust fmtjust test -p codex-core(2,676 passed; 80 unrelated environment failures from missing test binaries, sandbox signals, and read-only paths)