Skip to content

TUI Plugin Sharing 5 - polish remote plugin catalog rows - #26705

Merged
canvrno-oai merged 12 commits into
mainfrom
canvrno/plugin_sharing_tui_stack_pr5_labels_toggle_polish
Jun 25, 2026
Merged

TUI Plugin Sharing 5 - polish remote plugin catalog rows#26705
canvrno-oai merged 12 commits into
mainfrom
canvrno/plugin_sharing_tui_stack_pr5_labels_toggle_polish

Conversation

@canvrno-oai

@canvrno-oai canvrno-oai commented Jun 6, 2026

Copy link
Copy Markdown
Contributor

This is the final plugin sharing PR in the 5-PR stack. It applies the remaining TUI polish for remote plugin catalog rows and tabs: admin-disabled plugins now read as blocked/view-only instead of looking toggleable, admin-installed/default-installed plugins count and sort like installed plugins, plugin search matches richer metadata, and an empty successful Shared with me section stays hidden.

  • Admin-disabled rows use a blocked marker, show Disabled, and keep Enter-only detail behavior without a toggle hint.
  • Admin-installed/default-installed plugins show as installed in counts, ordering, tabs, and detail copy.
  • Plugin search now matches descriptions and keywords in addition to existing row metadata.
  • Successful-empty Shared with me tabs are hidden, while loading, error, workspace-empty, and real shared-plugin states remain visible.
  • Updates coverage in plugins_popup_snapshot_shows_all_marketplaces_and_sorts_installed_then_name, plugins_popup_admin_disabled_installed_plugin_has_no_toggle_hint, plugins_popup_search_matches_plugin_descriptions, and plugins_popup_remote_section_fallback_states_snapshot.
  • Updates snapshots plugins_popup_curated_marketplace and plugins_popup_empty_shared_section_hidden.
image image
@canvrno-oai canvrno-oai changed the title [codex] tui: polish remote plugin catalog rows TUI Plugin sharing - polish remote plugin catalog rows Jun 6, 2026
@canvrno-oai
canvrno-oai force-pushed the canvrno/plugin_sharing_tui_stack_pr5_labels_toggle_polish branch 2 times, most recently from f4b895f to fb25bbe Compare June 8, 2026 17:49
@canvrno-oai
canvrno-oai force-pushed the canvrno/plugin_sharing_tui_stack_pr4_remote_catalog_tests branch 2 times, most recently from 8f3923a to c300cb3 Compare June 8, 2026 18:03
@canvrno-oai
canvrno-oai force-pushed the canvrno/plugin_sharing_tui_stack_pr5_labels_toggle_polish branch from fb25bbe to 1606df5 Compare June 8, 2026 18:03
@canvrno-oai
canvrno-oai force-pushed the canvrno/plugin_sharing_tui_stack_pr4_remote_catalog_tests branch from c300cb3 to a8c121a Compare June 8, 2026 18:36
@canvrno-oai
canvrno-oai force-pushed the canvrno/plugin_sharing_tui_stack_pr5_labels_toggle_polish branch from 1606df5 to 072b5a7 Compare June 8, 2026 18:40
@canvrno-oai
canvrno-oai force-pushed the canvrno/plugin_sharing_tui_stack_pr4_remote_catalog_tests branch from a8c121a to 4d5c661 Compare June 8, 2026 19:01
@canvrno-oai
canvrno-oai force-pushed the canvrno/plugin_sharing_tui_stack_pr5_labels_toggle_polish branch 3 times, most recently from 1168f5c to 56793c8 Compare June 8, 2026 19:34
@canvrno-oai
canvrno-oai force-pushed the canvrno/plugin_sharing_tui_stack_pr4_remote_catalog_tests branch from a3c44df to f543572 Compare June 8, 2026 20:23
@canvrno-oai
canvrno-oai force-pushed the canvrno/plugin_sharing_tui_stack_pr5_labels_toggle_polish branch from 6339ba1 to e0e7dfa Compare June 8, 2026 20:23
@canvrno-oai canvrno-oai changed the title TUI Plugin sharing - polish remote plugin catalog rows TUI Plugin Sharing 5 Jun 9, 2026
@canvrno-oai canvrno-oai changed the title TUI Plugin Sharing 5 TUI Plugin Sharing 5 - polish remote plugin catalog rows Jun 9, 2026
@canvrno-oai
canvrno-oai force-pushed the canvrno/plugin_sharing_tui_stack_pr4_remote_catalog_tests branch from f543572 to 4cba5df Compare June 10, 2026 04:02
@canvrno-oai
canvrno-oai force-pushed the canvrno/plugin_sharing_tui_stack_pr5_labels_toggle_polish branch from e0e7dfa to 5a1e49a Compare June 10, 2026 04:04
@canvrno-oai
canvrno-oai force-pushed the canvrno/plugin_sharing_tui_stack_pr4_remote_catalog_tests branch from 10bc962 to 311d253 Compare June 17, 2026 01:56
@canvrno-oai
canvrno-oai force-pushed the canvrno/plugin_sharing_tui_stack_pr5_labels_toggle_polish branch 3 times, most recently from 2aad6ff to ffb3361 Compare June 17, 2026 03:20
@canvrno-oai
canvrno-oai force-pushed the canvrno/plugin_sharing_tui_stack_pr4_remote_catalog_tests branch from f8d7100 to d0ca565 Compare June 17, 2026 20:07
@canvrno-oai
canvrno-oai force-pushed the canvrno/plugin_sharing_tui_stack_pr5_labels_toggle_polish branch from 5932ded to db3cd02 Compare June 17, 2026 20:10
@canvrno-oai
canvrno-oai force-pushed the canvrno/plugin_sharing_tui_stack_pr4_remote_catalog_tests branch 3 times, most recently from 9493e4a to c433b9b Compare June 22, 2026 17:46
@canvrno-oai
canvrno-oai force-pushed the canvrno/plugin_sharing_tui_stack_pr5_labels_toggle_polish branch 2 times, most recently from d2c8b31 to 1372394 Compare June 22, 2026 23:31
@canvrno-oai
canvrno-oai force-pushed the canvrno/plugin_sharing_tui_stack_pr5_labels_toggle_polish branch 2 times, most recently from 34247ca to fa99b9b Compare June 23, 2026 00:31
Base automatically changed from canvrno/plugin_sharing_tui_stack_pr4_remote_catalog_tests to main June 23, 2026 00:31
@canvrno-oai
canvrno-oai force-pushed the canvrno/plugin_sharing_tui_stack_pr5_labels_toggle_polish branch from fa99b9b to fc3a69b Compare June 23, 2026 00:35
@canvrno-oai

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: aa5bff18e8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/tui/src/chatwidget/plugin_catalog.rs Outdated
Comment thread codex-rs/tui/src/chatwidget/plugin_catalog.rs Outdated
Comment thread codex-rs/tui/src/chatwidget/plugin_catalog.rs Outdated
@canvrno-oai
canvrno-oai marked this pull request as ready for review June 24, 2026 23:58
Comment thread codex-rs/tui/src/chatwidget/plugin_catalog.rs Outdated
@canvrno-oai
canvrno-oai merged commit a0d5fd7 into main Jun 25, 2026
31 checks passed
@canvrno-oai
canvrno-oai deleted the canvrno/plugin_sharing_tui_stack_pr5_labels_toggle_polish branch June 25, 2026 01:48
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 25, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

2 participants