Conversation
jif-oai
approved these changes
May 19, 2026
starr-openai
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
openai/codex#22169added a regression test that expects an invalid childservice_tierto be rejected, but the test usedResult::expect_erronSpawnAgentHandler::handle. That requires theOktype to implementDebug, and this handler returnsBox<dyn ToolOutput>, so Bazel failed while compilingcodex-coretests before it could run them.What changed
result.err()instead of callingexpect_err.FunctionCallError::RespondToModelassertion for the rejected service tier.Verification
cargo test -p codex-core spawn_agent_role_service_tier_does_not_hide_invalid_spawn_request