Skip to content

test: fix multi-agent service tier assertion#23576

Merged
bolinfest merged 1 commit into
mainfrom
pr23576
May 19, 2026
Merged

test: fix multi-agent service tier assertion#23576
bolinfest merged 1 commit into
mainfrom
pr23576

Conversation

@bolinfest
Copy link
Copy Markdown
Collaborator

@bolinfest bolinfest commented May 19, 2026

Why

openai/codex#22169 added a regression test that expects an invalid child service_tier to be rejected, but the test used Result::expect_err on SpawnAgentHandler::handle. That requires the Ok type to implement Debug, and this handler returns Box<dyn ToolOutput>, so Bazel failed while compiling codex-core tests before it could run them.

What changed

  • Capture the handler result and assert on result.err() instead of calling expect_err.
  • Keep the same FunctionCallError::RespondToModel assertion for the rejected service tier.

Verification

  • cargo test -p codex-core spawn_agent_role_service_tier_does_not_hide_invalid_spawn_request
@bolinfest bolinfest requested a review from a team as a code owner May 19, 2026 23:30
@bolinfest bolinfest requested a review from aibrahim-oai May 19, 2026 23:32
@bolinfest bolinfest changed the title Fix the build regression from openai/codex#22169 by avoiding Result::expect_err on a tool handler result whose Ok type i test: fix multi-agent service tier assertion May 19, 2026
@bolinfest bolinfest merged commit c58c84d into main May 19, 2026
44 of 45 checks passed
@bolinfest bolinfest deleted the pr23576 branch May 19, 2026 23:47
@github-actions github-actions Bot locked and limited conversation to collaborators May 19, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

3 participants