feat: support managed permission profiles in requirements.toml#23433
Merged
Conversation
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2525dd0355
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
bolinfest
reviewed
May 19, 2026
993dc86 to
1451511
Compare
bolinfest
reviewed
May 20, 2026
Collaborator
bolinfest
left a comment
There was a problem hiding this comment.
I will finish this review tomorrow!
Co-authored-by: Codex noreply@openai.com
Co-authored-by: Codex noreply@openai.com
Co-authored-by: Codex noreply@openai.com
Co-authored-by: Codex noreply@openai.com
Co-authored-by: Codex noreply@openai.com
3d59efc to
e0073d2
Compare
Co-authored-by: Codex noreply@openai.com
Co-authored-by: Codex noreply@openai.com
bolinfest
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Cloud-managed
requirements.tomlshould be able to define the managed permission profiles a client may select and constrain that selectable set without requiring local user config to recreate the profile catalog.This keeps requirements focused on restrictions. The selected default remains a config or session choice, while requirements contribute the managed profile bodies and
allowed_permissionsallowlist that the config-loading boundary validates before a resolved runtimePermissionProfileis installed.What changed
requirements.tomlsupport for a managed permission-profile catalog plus its allowlist:allowed_permissionsentry resolves to a built-in or catalog profile before selection uses it.:read-only/:workspacefallback path intact when no permission profile is explicitly selected.EffectivePermissionSelectionso the requirements boundary is visible in config loading.allowedPermissionsthroughconfigRequirements/read, and update the generated app-server schema fixtures plus the app-server README.Validation
cargo test -p codex-configcargo test -p codex-core system_requirements_cargo test -p codex-core system_allowed_permissions_cargo test -p codex-app-server-protocoljust write-app-server-schemaRelated work