cleanup: Remove skill env var dependency prompting#22721
Conversation
| }, | ||
| FeatureSpec { | ||
| id: Feature::SkillEnvVarDependencyPrompt, | ||
| key: "skill_env_var_dependency_prompt", | ||
| stage: Stage::UnderDevelopment, | ||
| default_enabled: false, |
There was a problem hiding this comment.
rm'ing outright would break for anyone who has it set. maybe make it Stage::Removed instead
There was a problem hiding this comment.
we are fail open to unrecognized feature, no?
There was a problem hiding this comment.
yea with warning. with --strict-config it breaks though. not a huge deal but we can play it safe
There was a problem hiding this comment.
codex:
This makes the test stop asserting that env_var dependencies are loaded, but the loader still accepts them in resolve_dependency_tool and keeps them in SkillMetadata.dependencies.tools. That means they are still surfaced through downstream skill metadata APIs; only the runtime prompt path was removed.
If the intended behavior is that env_var entries are "silently ignored during skill loading", should we filter them out in the loader and replace this deletion with a test that asserts they are dropped?
There was a problem hiding this comment.
Yeah, you can actually put whatever you want into dependencies — today it’s just treated as a string. It’s basically a “ignore what we don’t understand” model.
3 participants
Deletes the skill env var dependency prompt feature and its runtime path. env_var entries in skill dependency metadata are now silently ignored during skill loading.