Add unsigned macOS release artifacts#22559
Merged
Merged
Conversation
shijie-oai
commented
May 13, 2026
Comment on lines
+309
to
+321
| for binary in ${{ matrix.binaries }}; do | ||
| binary_path="${release_dir}/${binary}" | ||
| unsigned_name="${binary}-${target}-unsigned" | ||
| unsigned_path="${dest}/${unsigned_name}" | ||
| if [[ ! -f "${binary_path}" ]]; then | ||
| echo "Binary ${binary_path} not found" | ||
| exit 1 | ||
| fi | ||
|
|
||
| cp "${binary_path}" "${unsigned_path}" | ||
| tar -C "$dest" -czf "${unsigned_path}.tar.gz" "${unsigned_name}" | ||
| zstd -T0 -19 --rm "${unsigned_path}" | ||
| done |
Collaborator
Author
There was a problem hiding this comment.
This is before signing - so we copy the unsigned file and add -unsigned and put them aside.
shijie-oai
commented
May 13, 2026
Comment on lines
+41
to
+44
| if [[ "${GITHUB_EVENT_NAME}" == "workflow_dispatch" && "${SIGN_MACOS}" == "true" ]]; then | ||
| echo "❌ Manual rust-release runs must set sign_macos=false" | ||
| exit 1 | ||
| fi |
Collaborator
Author
There was a problem hiding this comment.
this would block any manual workflow trigger if the sign_macos is set to true or unset (default to true)
viyatb-oai
approved these changes
May 13, 2026
Collaborator
|
@shijie-oai @viyatb-oai I don't feel like this boolean for signing should be specific to MacOS: it should apply to all platforms. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
workflow_dispatchoption,sign_macos, defaulting totruesign_macos=false, skip macOS signing, signed-name macOS artifacts, DMGs, npm/DotSlash/PyPI publishing, latest release marking, andlatest-alpha-cliupdatesProcess
HAVE NOT TESTED YET BUT we should be able to run
which will then start the rust-release script with
sign_macosand therefore do not codesign mac and also no release afterward.