Remove plugin hooks feature flag#22552
Conversation
…-hooks-flag # Conflicts: # codex-rs/features/src/lib.rs
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a5e726bbcf
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| stage: Stage::Stable, | ||
| default_enabled: true, | ||
| }, |
There was a problem hiding this comment.
If a managed config pins features.plugin_hooks = false while leaving plugins enabled, deleting this feature key makes parse_feature_requirements classify that requirement as unknown and ignore it; because plugin hooks now follow plugin enablement directly, plugin-bundled hooks will run/list anyway. That silently weakens an admin-managed requirement instead of failing or migrating it, so workspaces that relied on this policy lose their hook block.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
I think this is acceptable, plugin_hooks flag was strictly for ourselves to gate the feature until we were confident in it
| default_enabled: true, | ||
| }, | ||
| FeatureSpec { | ||
| id: Feature::PluginHooks, |
There was a problem hiding this comment.
This should be retained and and marked Stage::Removed. If you delete it, users who have configured this feature flag will start to see failures at launch.
…back # Conflicts: # codex-rs/features/src/lib.rs
3 participants
Why
This is a follow-up stacked on top of the
plugin_hooksdefault-on change. Once we are comfortable making plugin hooks part of the normal plugin behavior, the separate feature flag stops buying us much and leaves extra branching/cache state behind.What
PluginHooksfeature and generated config-schema entriesplugin_hooks = true/false