Emit accepted line fingerprint analytics#21601
Conversation
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 614ca494c2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if host == "github.com" { | ||
| Some(format!("{host}/{}", path.to_ascii_lowercase())) | ||
| } else { | ||
| Some(format!("{host}/{path}")) |
There was a problem hiding this comment.
The commit promises SSH/HTTPS GitHub remotes join to the same repo hash, but ssh://git@github.com:22/OpenAI/Codex.git and https://github.com:443/openai/codex.git keep the port in host, so this branch skips the GitHub lowercasing/canonical host path and hashes them differently from git@github.com:OpenAI/Codex.git. This fragments attribution for valid Git remotes using default ports.
Useful? React with 👍 / 👎.
alexsong-oai
force-pushed
the
alexs/loc-accepted-events
branch
2 times, most recently
from
5dd8ab8 to
47956eb
Compare
alexsong-oai
force-pushed
the
alexs/loc-accepted-events
branch
from
47956eb to
90a5103
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 90a510352b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
alexsong-oai
force-pushed
the
alexs/loc-accepted-events
branch
2 times, most recently
from
15ed590 to
2015ce9
Compare
| @@ -0,0 +1,188 @@ | |||
| use crate::facts::AcceptedLineFingerprint; | |||
There was a problem hiding this comment.
I think you can combine this file with accepted_line_events.rs
| let mut current_batch = Vec::new(); | ||
|
|
||
| for event in events { | ||
| if event.should_send_in_isolated_request() { |
There was a problem hiding this comment.
I think it is good for now. But would love to learn if we need a separate queue for this event so it won't block other events.
alexsong-oai
force-pushed
the
alexs/loc-accepted-events
branch
from
2015ce9 to
98572b1
Compare
2 participants
Why
Codex assisted-code attribution needs a client-side accepted-code source that does not upload raw code. This adds a hash-only analytics event derived from the turn diff so downstream attribution can compare accepted Codex lines against commit or PR diffs.
What Changed
codex_accepted_line_fingerprintsanalytics.+++or---file headers.Verification
cargo test -p codex-analyticscargo test -p codex-git-utils canonicalize_git_remote_urljust fix -p codex-analyticsjust bazel-lock-checkgit diff --check