Skip to content

Remove skills list extra roots#21485

Merged
xli-oai merged 3 commits into
mainfrom
xli-codex/remove-skills-extra-roots
May 8, 2026
Merged

Remove skills list extra roots#21485
xli-oai merged 3 commits into
mainfrom
xli-codex/remove-skills-extra-roots

Conversation

@xli-oai
Copy link
Copy Markdown
Contributor

@xli-oai xli-oai commented May 7, 2026

Summary

  • Remove perCwdExtraUserRoots / SkillsListExtraRootsForCwd from the skills/list app-server API.
  • Drop Rust app-server and codex-core-skills extra-root plumbing so skill scans are keyed by the normal cwd/user/plugin roots only.
  • Regenerate app-server schemas and update docs/tests that only existed for the removed extra-roots behavior.

Validation

  • just write-app-server-schema
  • just fmt
  • cargo test -p codex-app-server-protocol
  • cargo test -p codex-core-skills
  • just fix -p codex-app-server-protocol
  • just fix -p codex-core-skills
  • just fix -p codex-app-server
  • just fix -p codex-tui

Notes

  • cargo test -p codex-app-server --test all skills_list ran the edited skills-list cases, but the full filtered run ended on existing skills_changed_notification_is_emitted_after_skill_change timeout after a websocket 401.
  • cargo test -p codex-tui --lib compiled the changed TUI callers, then failed two unrelated status permission tests because local /etc/codex/requirements.toml forbids DangerFullAccess.
  • Source-truth check found the OpenAI monorepo still has generated/app-server-kit mirror references to the removed field; those should be cleaned up when generated app-server types are synced or in a companion OpenAI cleanup.
@xli-oai xli-oai added the oai PRs contributed by OpenAI employees label May 7, 2026 — with ChatGPT Codex Connector
@xli-oai xli-oai force-pushed the xli-codex/remove-skills-extra-roots branch from 918933d to 9183997 Compare May 7, 2026 05:41
@xli-oai
Copy link
Copy Markdown
Contributor Author

xli-oai commented May 7, 2026

@codex review

@xli-oai xli-oai marked this pull request as ready for review May 7, 2026 08:44
@xli-oai
Copy link
Copy Markdown
Contributor Author

xli-oai commented May 8, 2026

@codex review

Copy link
Copy Markdown
Contributor

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

per_cwd_extra_user_roots: Annotated[
list[SkillsListExtraRootsForCwd] | None,
Field(
alias="perCwdExtraUserRoots",
description="Optional per-cwd extra roots to scan as user-scoped skills.",
),

P2 Badge Remove stale extra roots from Python SDK

The Rust v2 SkillsListParams and server handling no longer include perCwdExtraUserRoots, but the generated Python SDK still exposes and documents it. Python clients can keep sending this field and believe extra user roots are scanned, while the server now ignores it, so SDK behavior/documentation is out of sync with the API.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@xli-oai
Copy link
Copy Markdown
Contributor Author

xli-oai commented May 8, 2026

@codex review

@chatgpt-codex-connector
Copy link
Copy Markdown
Contributor

Codex Review: Didn't find any major issues. Bravo.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@xli-oai xli-oai force-pushed the xli-codex/remove-skills-extra-roots branch from 43496a4 to 8835b5b Compare May 8, 2026 03:00
@xli-oai xli-oai merged commit 314229f into main May 8, 2026
52 checks passed
@xli-oai xli-oai deleted the xli-codex/remove-skills-extra-roots branch May 8, 2026 03:56
@github-actions github-actions Bot locked and limited conversation to collaborators May 8, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

oai PRs contributed by OpenAI employees

2 participants