Avoid hard-coded environment context shell#21390
Merged
Merged
Conversation
starr-openai
force-pushed
the
starr/env-context-shell-hint-20260506
branch
7 times, most recently
from
8a1603b to
2a7c2fb
Compare
pakrym-oai
approved these changes
May 6, 2026
starr-openai
force-pushed
the
starr/env-context-shell-hint-20260506
branch
2 times, most recently
from
e1d7f3b to
f87717a
Compare
Represent resolved turn environment shell metadata as optional, and render environment context shells from explicit per-environment metadata when present or the existing session shell otherwise. This avoids claiming bash for multi-environment Windows turns when the resolver has no shell metadata. Update prompt-caching tests to expect the platform default session shell when asserting the baseline environment context. Tests not run (CI exercises the Windows Bazel lane; ran just fmt). Co-authored-by: Codex <noreply@openai.com>
starr-openai
force-pushed
the
starr/env-context-shell-hint-20260506
branch
from
f87717a to
14f471a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
just fmt).