[codex] Handle git pagination flags by position#21381
Merged
Merged
Conversation
evawong-oai
approved these changes
May 6, 2026
Contributor
evawong-oai
left a comment
There was a problem hiding this comment.
Approved. Security review found no High issues caused by this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
This is a follow-up to the Windows Git safe-command bypass fix for BUGB-15601. Git's global
--paginate/-pflags can route output through a configured pager, so they should not be auto-approved as safe before the subcommand. At the same time,-pafter read-only subcommands likelog,diff, andshowis the common patch-output flag, so treating every-pas unsafe would make ordinary read-only inspection commands prompt unnecessarily.What Changed
git --paginate ...andgit -p ...as unsafe.git log -p,git diff -p, andgit show -p HEADsafe.git_global_option_requires_prompthelper now that safe-command Git option matching owns the prompt-required lists.Testing
cargo test -p codex-shell-command