feat(app-server): move v2 sessionId onto Thread#21336
Merged
Merged
Conversation
sessionId on Thread
sessionId on ThreadsessionId onto Thread
aibrahim-oai
approved these changes
May 6, 2026
Collaborator
Author
|
@codex review |
Contributor
|
Codex Review: Didn't find any major issues. Another round soon, please! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
session_idandthread_idare separate identities after #20437, but app-server only surfacedsessionIdon thethread/start,thread/resume, andthread/forkresponse envelopes. Other thread-bearing surfaces such asthread/list,thread/read,thread/started,thread/rollback,thread/metadata/update, andthread/unarchiveeither lacked the grouping key or forced clients to special-case those three responses.Making
sessionIdpart of the reusableThreadpayload gives every v2 API surface one place to expose session-tree identity.Mental model
ThreadWhat changed
sessionIdto the v2Thread.sessionIdfields fromthread/start,thread/resume, andthread/fork; clients should now readresponse.thread.sessionId.thread.sessionIdwhen building live thread responses, replaying loaded threads, and returning stored-thread summaries so the field is present across start, resume, fork, list, read, rollback, metadata-update, unarchive, andthread/startedpaths. Seeload_thread_from_resume_source_or_send_internalandthread_from_stored_thread.thread.sessionIdfalls back tothread.id; once the thread is live again, the field reports the active session tree root.thread.sessionIdon the thread object.