Enable V8 sandboxing for source-built builds#21146
Merged
Merged
Conversation
Add the V8 build flags and Rust feature plumbing needed for in-process sandboxing, default source-built Bazel consumers to sandbox-enabled artifacts, and keep published rusty_v8 release workflows on the existing non-sandboxed contract until matching release artifacts are available. Allow the temporary sandbox forwarding features while the V8 artifact migration is in flight.
cconger
force-pushed
the
cconger/v8-sandbox-probe
branch
from
947d292 to
c4e1127
Compare
bolinfest
reviewed
May 5, 2026
Comment on lines
+28
to
+31
| MANIFEST_FEATURE_EXCEPTIONS = { | ||
| "codex-rs/code-mode/Cargo.toml": {"sandbox": ("v8/v8_enable_sandbox",)}, | ||
| "codex-rs/v8-poc/Cargo.toml": {"sandbox": ("v8/v8_enable_sandbox",)}, | ||
| } |
Collaborator
There was a problem hiding this comment.
This was here as part of the transition. The purpose of this is to categorically disallow features in our Cargo workspace because we end up building more permutations of crates.
Contributor
Author
There was a problem hiding this comment.
At the end of PR 4 this should be removed completely, but this is a temporary exception will allow me to migrate in the short term since the source for producing our artifacts is version locked (same repo) as the code on the consumer side for v8 that we bazel build.
The goal is to have these default on, and no feature to disable.
bolinfest
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is the first PR in the V8 in-process sandboxing rollout.
It adds the build-system and Rust feature plumbing needed to support sandboxed V8 builds, then enables sandboxing by default for the source-built Bazel V8 path that we control directly. It deliberately keeps the published
rusty_v8artifact workflows on their current non-sandboxed contract so this PR can land and ship independently before we change any released artifacts.Rollout plan
PR 1: land sandbox plumbing and default source-built Bazel V8 to sandboxed mode
PR 2: publish sandbox-enabled release artifacts and add compatibility validation
codex-v8-pocreports sandbox enabledcodex-code-modebuilds/tests against the sandboxed pathPR 3: switch release consumers to sandboxed artifacts by default
v8_enable_sandboxfeature in the default release path.PR 4: remove rollout-only compatibility paths