Rename agent identity login surface to access token#21059
Merged
Conversation
shijie-oai
force-pushed
the
shijie/access-token-agent-identity-login
branch
from
f7f73ce to
c200771
Compare
shijie-oai
commented
May 4, 2026
| with_api_key: bool, | ||
|
|
||
| #[arg( | ||
| long = "with-agent-identity", |
Collaborator
Author
There was a problem hiding this comment.
So we are doing a "hard delete" and not keeping this around for backward compatibility - this is still a WIP feature and we are finalizing the branding here so should not have any user affect. Do let me know if we prefer to keep it around though to make it not so "breaking". Same thing applies to CODEX_AGENT_IDENTITY env read/consumption.
Collaborator
There was a problem hiding this comment.
any external users already, or not possible?
Collaborator
Author
There was a problem hiding this comment.
Not possible - we have a few alpha testers and we can inform them of this change.
efrazer-oai
approved these changes
May 4, 2026
sayan-oai
reviewed
May 4, 2026
sayan-oai
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The external startup/login surface for this auth path should talk about an access token instead of exposing the internal Agent Identity terminology. Users should pass
CODEX_ACCESS_TOKENor pipe a token intocodex login --with-access-token; the old external env/flag spellings are removed so there is only one supported user-facing path.What Changed
CODEX_ACCESS_TOKENas the supported environment variable for this auth path.codex login --with-access-tokenas the supported stdin-based login command.CODEX_AGENT_IDENTITYenv-var fallback and hidden--with-agent-identityCLI alias.Validation
cargo test -p codex-logincargo test -p codex-clijust fix -p codex-loginjust fix -p codex-cli