Skip to content

[codex] Migrate loaded thread/read history to ThreadStore#20486

Merged
wiltzius-openai merged 1 commit into
mainfrom
wiltzius/codex/thread-read-store-history
May 1, 2026
Merged

[codex] Migrate loaded thread/read history to ThreadStore#20486
wiltzius-openai merged 1 commit into
mainfrom
wiltzius/codex/thread-read-store-history

Conversation

@wiltzius-openai
Copy link
Copy Markdown
Contributor

@wiltzius-openai wiltzius-openai commented Apr 30, 2026

Summary

  • Route loaded thread/read + includeTurns through CodexThread::load_history / ThreadStore history instead of direct rollout JSONL reads.
  • Add an in-memory ThreadStore regression test covering loaded thread/read includeTurns without a local rollout path.
@wiltzius-openai wiltzius-openai force-pushed the wiltzius/codex/thread-read-store-history branch 3 times, most recently from ad9e42d to 6259599 Compare April 30, 2026 21:28
@wiltzius-openai wiltzius-openai marked this pull request as ready for review April 30, 2026 21:58
Copy link
Copy Markdown
Contributor

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6259599856

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/app-server/src/codex_message_processor.rs
@wiltzius-openai wiltzius-openai force-pushed the wiltzius/codex/thread-read-store-history branch from 6259599 to 9fde4c6 Compare May 1, 2026 02:34
@wiltzius-openai wiltzius-openai merged commit e4d6675 into main May 1, 2026
25 checks passed
@wiltzius-openai wiltzius-openai deleted the wiltzius/codex/thread-read-store-history branch May 1, 2026 17:55
@github-actions github-actions Bot locked and limited conversation to collaborators May 1, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

2 participants