feat(rollouts): store EventMsg::ApplyPatchEnd in limited history mode#20463
Merged
Conversation
jif-oai
approved these changes
Apr 30, 2026
| } | ||
|
|
||
| #[test] | ||
| fn persists_patch_apply_end_events_in_limited_mode() { |
Collaborator
There was a problem hiding this comment.
tbh I don't think this test brings anything but load on the CI pipeline
Collaborator
Author
There was a problem hiding this comment.
fair, down to remove
Collaborator
Author
There was a problem hiding this comment.
deleted the entire suite since they all did similar things
owenlin0
force-pushed
the
owen/persist_apply_patch_for_limited_history
branch
from
27cb5da to
7ec0a94
Compare
owenlin0
force-pushed
the
owen/persist_apply_patch_for_limited_history
branch
from
418f9bd to
eaeb87f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Codex App treats apply patch tool calls quite load-bearing in the UI (always shown on a completed turn), so we'd like to persist
EventMsg::ApplyPatchEndto guarantee that when a client reconnects to app-server mid-turn, we always have the full diff to display at the end of that turn.