Make thread store process-scoped by wiltzius-openai · Pull Request #19474 · openai/codex

wiltzius-openai · 2026-04-25T00:53:42Z

Build one app-server process ThreadStore from startup config and share it with ThreadManager and CodexMessageProcessor.
Remove per-thread/fork store reconstruction so effective thread config cannot switch the persistence backend.
Add params to ThreadStore create/resume for specifying thread metadata, since otherwise the metadata from store creation would be used (incorrectly).

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8f6aed7f69

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

wiltzius-openai · 2026-04-30T20:32:17Z

@codex review

wiltzius-openai · 2026-04-30T20:40:17Z

@codex review

chatgpt-codex-connector

💡 Codex Review

codex/codex-rs/thread-store/src/remote/mod.rs

Lines 62 to 71 in 0c9e6b1

    
           let request = proto::CreateThreadRequest { 
        
               thread_id: thread_id.to_string(), 
        
               forked_from_id: params.forked_from_id.map(|thread_id| thread_id.to_string()), 
        
               source: Some(helpers::proto_session_source(&params.source)), 
        
               base_instructions_json: helpers::base_instructions_json(&params.base_instructions)?, 
        
               dynamic_tools_json: helpers::dynamic_tools_json(&params.dynamic_tools)?, 
        
               event_persistence_mode: helpers::proto_event_persistence_mode( 
        
                   params.event_persistence_mode, 
        
               ) 
        
               .into(),

Forward per-thread metadata in remote create_thread requests

CreateThreadParams now includes metadata (cwd, model_provider, memory_mode), but RemoteThreadStore::create_thread still serializes only the old fields, and the protobuf has no slots for the new data. With experimental_thread_store = remote, newly created threads will persist without the per-thread metadata that local storage now records, so remote-backed thread summaries and memory-mode state diverge from local behavior.

codex/codex-rs/thread-store/src/remote/mod.rs

Lines 87 to 96 in 0c9e6b1

    
           let request = proto::ResumeThreadRequest { 
        
               thread_id: thread_id.to_string(), 
        
               rollout_path: params 
        
                   .rollout_path 
        
                   .map(|path| path.to_string_lossy().into_owned()), 
        
               history_json, 
        
               has_history, 
        
               include_archived: params.include_archived, 
        
               event_persistence_mode: helpers::proto_event_persistence_mode( 
        
                   params.event_persistence_mode,

Pass metadata_defaults through remote resume_thread

This commit added ResumeThreadParams::metadata_defaults specifically to stop resumed legacy threads from falling back to process-wide defaults, but RemoteThreadStore::resume_thread still drops that field. Remote-backed resumes therefore continue reconstructing older threads with the server default provider instead of the thread’s effective provider, so the metadata-fix only works for the local backend.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

wiltzius-openai · 2026-04-30T20:54:01Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 20b550dbfc

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

wiltzius-openai · 2026-04-30T21:10:33Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: de4d98da1c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

wiltzius-openai · 2026-04-30T23:40:49Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 467be306e0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

wiltzius-openai · 2026-04-30T23:49:50Z

@codex review

wiltzius-openai · 2026-04-30T23:55:01Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f1b45e9c93

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

wiltzius-openai · 2026-05-01T00:44:16Z

@codex review

chatgpt-codex-connector · 2026-05-01T00:52:34Z

Codex Review: Didn't find any major issues. Keep it up!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

wiltzius-openai · 2026-05-01T00:52:56Z

@codex review

chatgpt-codex-connector · 2026-05-01T01:02:37Z

Codex Review: Didn't find any major issues. 🎉

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

wiltzius-openai marked this pull request as ready for review April 25, 2026 00:54

wiltzius-openai requested a review from a team as a code owner April 25, 2026 00:54

wiltzius-openai assigned pakrym-oai Apr 25, 2026

pakrym-oai approved these changes Apr 25, 2026

View reviewed changes

chatgpt-codex-connector Bot reviewed Apr 25, 2026

View reviewed changes

Comment thread codex-rs/core/src/thread_manager.rs

This was referenced Apr 25, 2026

📊 AI CLI 工具社区动态日报 2026-04-25 gsscsd/big_model_radar#240

Open

📊 AI CLI 工具社区动态日报 2026-04-25 borq168/big_model_radar#13

Open

📊 AI CLI Tools Digest 2026-04-25 borq168/big_model_radar#16

Open

wiltzius-openai force-pushed the wiltzius/codex/process-thread-store branch 2 times, most recently from 4deefa1 to ede3d32 Compare April 30, 2026 17:48

wiltzius-openai added a commit that referenced this pull request Apr 30, 2026

codex: fix CI failure on PR #19474

9ce12ca

wiltzius-openai added a commit that referenced this pull request Apr 30, 2026

codex: fix CI failure on PR #19474

92ad3c3

wiltzius-openai force-pushed the wiltzius/codex/process-thread-store branch from 9ce12ca to 92ad3c3 Compare April 30, 2026 18:39

wiltzius-openai added a commit that referenced this pull request Apr 30, 2026

codex: fix CI failure on PR #19474

0c9e6b1

wiltzius-openai force-pushed the wiltzius/codex/process-thread-store branch from 92ad3c3 to 0c9e6b1 Compare April 30, 2026 18:54

chatgpt-codex-connector Bot reviewed Apr 30, 2026

View reviewed changes

wiltzius-openai added a commit that referenced this pull request Apr 30, 2026

codex: fix CI failure on PR #19474

44aa6fc

wiltzius-openai added a commit that referenced this pull request Apr 30, 2026

codex: address PR review feedback (#19474)

20b550d

wiltzius-openai force-pushed the wiltzius/codex/process-thread-store branch from 0c9e6b1 to 20b550d Compare April 30, 2026 20:53

chatgpt-codex-connector Bot reviewed Apr 30, 2026

View reviewed changes

Comment thread codex-rs/core/src/agent/control.rs

Comment thread codex-rs/app-server/src/message_processor.rs

wiltzius-openai added a commit that referenced this pull request Apr 30, 2026

codex: address follow-up PR review feedback (#19474)

de4d98d

chatgpt-codex-connector Bot reviewed Apr 30, 2026

View reviewed changes

Comment thread codex-rs/app-server/src/codex_message_processor.rs

wiltzius-openai added a commit that referenced this pull request Apr 30, 2026

codex: fix CI failure on PR #19474

ee0c9d7

wiltzius-openai added a commit that referenced this pull request Apr 30, 2026

codex: address PR review feedback (#19474)

83197ba

wiltzius-openai added a commit that referenced this pull request Apr 30, 2026

codex: address follow-up PR review feedback (#19474)

a089440

wiltzius-openai added a commit that referenced this pull request Apr 30, 2026

codex: fix follow-up review and CI (#19474)

b2cbd67

chatgpt-codex-connector Bot reviewed Apr 30, 2026

View reviewed changes

Comment thread codex-rs/thread-store/src/local/live_writer.rs Outdated

Comment thread codex-rs/thread-store/src/local/read_thread.rs

chatgpt-codex-connector Bot reviewed May 1, 2026

View reviewed changes

Comment thread codex-rs/core/src/thread_manager.rs Outdated

Comment thread codex-rs/thread-store/src/local/helpers.rs

wiltzius-openai added 15 commits April 30, 2026 17:35

Make thread store process-scoped

9e92a9e

Keep local store config process-scoped

c018bb2

Fix TUI memory mode test fixture

4463449

codex: fix CI failure on PR #19474

029ba75

codex: address PR review feedback (#19474)

2359eaf

codex: address follow-up PR review feedback (#19474)

d974165

codex: fix follow-up review and CI (#19474)

d682e4f

codex: fix rebase fallout (#19474)

6d01211

codex: tighten running path resume validation (#19474)

53d7dbb

codex: honor path precedence for running resumes

9f42522

codex: reuse local writer for active resumes

7656f73

codex: tighten thread store metadata lifecycle

27c766a

codex: fix thread store memory test setup

a5f5b9c

codex: reject duplicate live thread resumes

252be3d

codex: respect archived live rollout reads

b9ececf

wiltzius-openai force-pushed the wiltzius/codex/process-thread-store branch from f1b45e9 to df35d23 Compare May 1, 2026 00:44

codex: preserve active thread resume behavior

a2db94e

wiltzius-openai force-pushed the wiltzius/codex/process-thread-store branch from df35d23 to a2db94e Compare May 1, 2026 00:52

wiltzius-openai merged commit fe05aca into main May 1, 2026
25 checks passed

wiltzius-openai deleted the wiltzius/codex/process-thread-store branch May 1, 2026 04:25

github-actions Bot locked and limited conversation to collaborators May 1, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make thread store process-scoped#19474

Make thread store process-scoped#19474
wiltzius-openai merged 16 commits into
mainfrom
wiltzius/codex/process-thread-store

wiltzius-openai commented Apr 25, 2026 •

edited

Loading

chatgpt-codex-connector Bot left a comment

Uh oh!

wiltzius-openai commented Apr 30, 2026

wiltzius-openai commented Apr 30, 2026

chatgpt-codex-connector Bot left a comment

wiltzius-openai commented Apr 30, 2026

chatgpt-codex-connector Bot left a comment

Uh oh!

Uh oh!

wiltzius-openai commented Apr 30, 2026

chatgpt-codex-connector Bot left a comment

Uh oh!

wiltzius-openai commented Apr 30, 2026

chatgpt-codex-connector Bot left a comment

Uh oh!

Uh oh!

wiltzius-openai commented Apr 30, 2026

wiltzius-openai commented Apr 30, 2026

chatgpt-codex-connector Bot left a comment

Uh oh!

Uh oh!

wiltzius-openai commented May 1, 2026

chatgpt-codex-connector Bot commented May 1, 2026

wiltzius-openai commented May 1, 2026

chatgpt-codex-connector Bot commented May 1, 2026

Uh oh!

Labels

2 participants

	let request = proto::CreateThreadRequest {
	thread_id: thread_id.to_string(),
	forked_from_id: params.forked_from_id.map(\|thread_id\| thread_id.to_string()),
	source: Some(helpers::proto_session_source(&params.source)),
	base_instructions_json: helpers::base_instructions_json(&params.base_instructions)?,
	dynamic_tools_json: helpers::dynamic_tools_json(&params.dynamic_tools)?,
	event_persistence_mode: helpers::proto_event_persistence_mode(
	params.event_persistence_mode,
	)
	.into(),

	let request = proto::ResumeThreadRequest {
	thread_id: thread_id.to_string(),
	rollout_path: params
	.rollout_path
	.map(\|path\| path.to_string_lossy().into_owned()),
	history_json,
	has_history,
	include_archived: params.include_archived,
	event_persistence_mode: helpers::proto_event_persistence_mode(
	params.event_persistence_mode,

Conversation

wiltzius-openai commented Apr 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

wiltzius-openai commented Apr 30, 2026

wiltzius-openai commented Apr 30, 2026

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

wiltzius-openai commented Apr 30, 2026

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

wiltzius-openai commented Apr 30, 2026

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

wiltzius-openai commented Apr 30, 2026

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

wiltzius-openai commented Apr 30, 2026

wiltzius-openai commented Apr 30, 2026

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

wiltzius-openai commented May 1, 2026

chatgpt-codex-connector Bot commented May 1, 2026

wiltzius-openai commented May 1, 2026

chatgpt-codex-connector Bot commented May 1, 2026

Uh oh!

Labels

2 participants

wiltzius-openai commented Apr 25, 2026 •

edited

Loading