feat: surface multi-agent thread limit in spawn description#19360
Merged
Conversation
Co-authored-by: Codex <noreply@openai.com>
Collaborator
Author
|
@codex review |
Contributor
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
agent_max_threadsintoToolsConfigandSpawnAgentToolOptions.max_concurrent_threads_per_sessionvalue in the MultiAgentV2spawn_agentdescription.codex-toolsunit tests andcodex-coretool spec tests.Validation
just fmtcargo test -p codex-toolscargo test -p codex-core spawn_agent_descriptiongit diff --checkNotes
cargo test -p codex-corewas also attempted, but unrelated environment-sensitive tests failed with the active local environment. Examples: approvals reviewer defaults observedAutoReviewinstead ofUser, request-permissions event tests did not emit events, and proxy-env tests sawhttp://127.0.0.1:50604from the active proxy environment.