check PID of named pipe consumer#19283
Merged
Merged
Conversation
viyatb-oai
reviewed
Apr 24, 2026
Co-authored-by: Codex noreply@openai.com
viyatb-oai
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The elevated Windows command runner currently trusts the first process that connects to its parent-created named pipes. Tightening the pipe ACL already narrows who can reach that boundary, but verifying the connected client PID gives the parent one more fail-closed check: it only accepts the exact runner process it just spawned.
What changed
GetNamedPipeClientProcessIdafterConnectNamedPipeand reject clients whose PID does not match the spawned runnerwindows-sandbox-rs/src/elevated_impl.rsthroughspawn_runner_transport()so both elevated codepaths use the same pipe bootstrap and PID validationUsing the transport unification here also reduces duplication in the elevated Windows IPC bootstrap, so future hardening to the runner handshake only needs to land in one place.
Validation
cargo test -p codex-windows-sandboxtarget/debug/codex.exe execrunning a randomized shell command and confirming captured outputtarget/debug/codex.exe -c 'windows.sandbox="elevated"' sandbox windows -- python -u -c ...with stdin/stdout round-trips (READY, thenGOT:...for two input lines)