Skip to content

feat(auto-review) short-circuit#18890

Merged
dylan-hurd-oai merged 3 commits into
mainfrom
dh--auto-review--short-circuit
Apr 22, 2026
Merged

feat(auto-review) short-circuit#18890
dylan-hurd-oai merged 3 commits into
mainfrom
dh--auto-review--short-circuit

Conversation

@dylan-hurd-oai
Copy link
Copy Markdown
Collaborator

Summary

Short circuit the convo if auto-review hits too many denials

Testing

  • Added unit tests
@won-openai won-openai marked this pull request as ready for review April 21, 2026 23:52
@won-openai won-openai requested a review from a team as a code owner April 21, 2026 23:52
@won-openai won-openai marked this pull request as draft April 21, 2026 23:53
@won-openai won-openai marked this pull request as ready for review April 21, 2026 23:56
Copy link
Copy Markdown
Contributor

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 264bff1aa3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/core/src/guardian/review.rs Outdated
dylan-hurd-oai and others added 3 commits April 22, 2026 12:39
Emit guardian-origin warnings as a dedicated v2 guardianWarning notification while preserving existing warning rendering in the TUI. Regenerate app-server protocol schemas for the new payload type.

Co-authored-by: Codex <noreply@openai.com>
@dylan-hurd-oai dylan-hurd-oai force-pushed the dh--auto-review--short-circuit branch from 456b3b9 to 7b29135 Compare April 22, 2026 20:07
@dylan-hurd-oai dylan-hurd-oai enabled auto-merge (squash) April 22, 2026 20:29
@dylan-hurd-oai dylan-hurd-oai merged commit ed4def8 into main Apr 22, 2026
25 checks passed
@dylan-hurd-oai dylan-hurd-oai deleted the dh--auto-review--short-circuit branch April 22, 2026 20:34
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 22, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

2 participants