Conversation
bolinfest
changed the title
pakrym-oai
reviewed
Apr 17, 2026
| load_requirements_toml( | ||
| LOCAL_FS.as_ref(), | ||
| &mut config_requirements_toml, | ||
| &requirements_file, |
Collaborator
There was a problem hiding this comment.
requirements_file.abs()
pakrym-oai
approved these changes
Apr 17, 2026
jif-oai
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
origin/mainpicked up two changes that crossed in flight:ExecutorFileSystem, changingload_requirements_tomlto take a filesystem handle and anAbsolutePathBuf.deny_readrequirements tests that still calledload_requirements_tomlwith the previous two-argument signature.Once both landed,
just clippyfailed because the new tests no longer matched the current helper API.What
deny_readrequirements tests to convert the fixture path toAbsolutePathBufbefore loading.LOCAL_FS.as_ref()intoload_requirements_tomlso these tests follow the filesystem abstraction introduced by Refactor config loading to use filesystem abstraction #18209.Verification
just clippycargo test -p codex-core load_requirements_toml_resolves_deny_readcargo test -p codex-core --test all unified_exec_enforces_glob_deny_read_policy