Make MCP resource read threadless#18292
Merged
Merged
Conversation
…source-read-threadless # Conflicts: # codex-rs/app-server/tests/suite/v2/mcp_resource.rs
…source-read-threadless
shijie-oai
reviewed
Apr 21, 2026
Collaborator
shijie-oai
left a comment
shijie-oai
left a comment
There was a problem hiding this comment.
What was resource/read used for? Just want to make sure I understand.
Collaborator
Author
The app-server clients (Codex App) need to read UI widgets from MCP servers. |
shijie-oai
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Making thread id optional so that we can better cache resources for MCPs for connectors since their resource templates is universal and not particular to projects.
mcpServer/resource/readaccept an optionalthreadIdthreadIdis presentTesting
just write-app-server-schemajust fmtcargo test -p codex-app-server-protocolcargo test -p codex-mcpcargo test -p codex-app-server --test all mcp_resourcejust fix -p codex-mcpjust fix -p codex-app-server-protocoljust fix -p codex-app-server