Make yolo skip managed-network tool enforcement#18042
Merged
Merged
Conversation
4256190 to
b9475d6
Compare
Collaborator
Author
|
@codex review |
Contributor
|
Codex Review: Didn't find any major issues. Chef's kiss. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
dylan-hurd-oai
approved these changes
Apr 16, 2026
Collaborator
dylan-hurd-oai
left a comment
There was a problem hiding this comment.
cc @bolinfest for visibility as well
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This makes
DangerFullAccess/ yolo tool execution fully opt out of managed-network enforcement.Previously, yolo turns could have
turn.networkstripped while tool orchestration still derivedenforce_managed_network=truefromrequirements.toml.network. That created an inconsistent state where the turn had no managed proxy attached, but tool execution still behaved like managed networking was active.This updates the tool orchestration and JS REPL paths to treat managed networking as active only when the current turn actually has
turn.network.Behavior
DangerFullAccess: no managed proxy, no managed-network enforcement.Tests
just fmtcargo test -p codex-core danger_full_access_tool_attempts_do_not_enforce_managed_network -- --nocapturecargo test -p codex-core danger_full_access -- --nocapturejust fix -p codex-core