Skip to content

Make yolo skip managed-network tool enforcement#18042

Merged
won-openai merged 4 commits into
mainfrom
good-old-yolo-really-yolo
Apr 16, 2026
Merged

Make yolo skip managed-network tool enforcement#18042
won-openai merged 4 commits into
mainfrom
good-old-yolo-really-yolo

Conversation

@won-openai
Copy link
Copy Markdown
Collaborator

Summary

This makes DangerFullAccess / yolo tool execution fully opt out of managed-network enforcement.

Previously, yolo turns could have turn.network stripped while tool orchestration still derived enforce_managed_network=true from requirements.toml.network. That created an inconsistent state where the turn had no managed proxy attached, but tool execution still behaved like managed networking was active.

This updates the tool orchestration and JS REPL paths to treat managed networking as active only when the current turn actually has turn.network.

Behavior

  • Yolo / DangerFullAccess: no managed proxy, no managed-network enforcement.
  • Guardian / workspace-write with managed proxy: managed-network enforcement still applies.
  • Avoids the half-state where yolo has no proxy but still gets managed-network sandbox behavior.

Tests

  • just fmt
  • cargo test -p codex-core danger_full_access_tool_attempts_do_not_enforce_managed_network -- --nocapture
  • cargo test -p codex-core danger_full_access -- --nocapture
  • just fix -p codex-core
@won-openai won-openai force-pushed the good-old-yolo-really-yolo branch from 4256190 to b9475d6 Compare April 16, 2026 01:43
@won-openai
Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector
Copy link
Copy Markdown
Contributor

Codex Review: Didn't find any major issues. Chef's kiss.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copy link
Copy Markdown
Collaborator

@dylan-hurd-oai dylan-hurd-oai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @bolinfest for visibility as well

@won-openai won-openai enabled auto-merge (squash) April 16, 2026 09:02
@won-openai won-openai disabled auto-merge April 16, 2026 16:06
@won-openai won-openai merged commit 3a4fa77 into main Apr 16, 2026
34 of 36 checks passed
@won-openai won-openai deleted the good-old-yolo-really-yolo branch April 16, 2026 16:06
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 16, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

3 participants