Auto install start-codex-exec.sh dependencies#17990
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 11c4f31c9f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| echo "remote rsync is required on ${remote_host}" >&2 | ||
| exit 1 | ||
| fi | ||
| ssh "${remote_host}" -C "sudo apt-get install rsync libcap-dev" |
There was a problem hiding this comment.
The new unconditional sudo apt-get install ... call makes the script fail on remote hosts that don't have apt-get or passwordless sudo, even when required tools are already installed. This is a functional regression from the previous behavior that only checked for rsync presence.
Useful? React with 👍 / 👎.
pakrym-oai
deleted the
pakrym/auto-install-start-codex-exec-sh-dependencies
branch
2 participants
No description provided.