Conversation
b1c161a to
ddb0b2d
Compare
pakrym-oai
approved these changes
Apr 15, 2026
viyatb-oai
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
spawn_command_under_seatbelt()incodex-rs/core/src/seatbelt.rshad fallen out of production use and was only referenced by test-only wrappers. That left us with sandbox tests that could stay green even if the actual seatbelt exec path regressed, because production shell execution now flows throughSandboxManager::transform()andExecRequest::from_sandbox_exec_request()instead of that helper.Removing the dead helper also exposed one downstream
codex-execintegration test that still imported it, which brokejust clippy.What Changed
codex-rs/core/src/seatbelt.rsand stopped exportingcodex_core::seatbelt.codex-rs/core/tests/suite/seatbelt.rscoverage that only exercised the dead helper.openptyregression check, but moved it intocodex-rs/core/tests/suite/exec.rsso it now runs throughprocess_exec_tool_call().codex-rs/core/tests/suite/exec.rsto use/usr/bin/touch, so it actually exercises the sandbox instead of a nonexistent path.codex-rs/exec/tests/suite/sandbox.rson macOS to build the sandboxed command throughbuild_exec_request()and spawn the transformed command, instead of importing the removed helper.codex-rs/sandboxing/src/seatbelt_tests.rs, where the policy generator is still covered directly.Verification
cargo test -p codex-core suite::exec::cargo test -p codex-execcargo clippy -p codex-exec --tests -- -D warnings