Make skill loading filesystem-aware#17720
Conversation
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a459c3e3d9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…to pakrym/skill-loading-fs-full-ci # Conflicts: # codex-rs/core/src/codex.rs # codex-rs/core/src/plugins/manager.rs # codex-rs/core/src/plugins/manager_tests.rs # codex-rs/core/src/thread_manager.rs
…fs-full-ci # Conflicts: # codex-rs/core/src/codex.rs # codex-rs/core/src/plugins/manager.rs # codex-rs/core/src/thread_manager.rs
starr-openai
left a comment
starr-openai
left a comment
There was a problem hiding this comment.
let's add an ExecutorAbsolutePath or something like that sooner rather than later - this was we can just pass in the path object and many of these changes are drop in replacements.
As is we have to thread in the filesystem and remember to use that for all fs operations on the path (eg calling cwd.ancestors() right now is host local, not the executor side ancestors)
This reverts commit 31a01bf.
…fs-full-ci # Conflicts: # codex-rs/core-skills/src/loader.rs
2 participants
Migrates skill loading to support reading repo skills from the remote environment.