thread store interface#17659
Merged
Merged
Conversation
wiltzius-openai
force-pushed
the
wiltzius/codex/thread-store-abstraction
branch
4 times, most recently
from
921c3a3 to
7adf7ef
Compare
wiltzius-openai
commented
Apr 14, 2026
| fn is_terminal_thread_read_error(err: &color_eyre::Report) -> bool { | ||
| err.chain() | ||
| .any(|cause| cause.to_string().contains("thread not loaded:")) | ||
| err.chain().any(|cause| { |
Contributor
Author
There was a problem hiding this comment.
unintentional during unit test fixing, will remove
wiltzius-openai
force-pushed
the
wiltzius/codex/thread-store-abstraction
branch
from
7adf7ef to
51a470a
Compare
pakrym-oai
reviewed
Apr 14, 2026
Comment on lines
+54
to
+56
| pub originator: String, | ||
| /// CLI/app version creating the thread. | ||
| pub cli_version: String, |
Collaborator
There was a problem hiding this comment.
should originator and cli_version be on params? or should thread store already know about them?
Contributor
Author
There was a problem hiding this comment.
Already know about them by virtue of it knowing its own version (for cli_version) and operating context (for originator)? I think that's doable yes, assuming the originator is baked in somehow.
pakrym-oai
reviewed
Apr 14, 2026
|
|
||
| /// Describes who owns a thread for multi-tenant storage backends. | ||
| #[derive(Clone, Debug, Default, PartialEq, Eq, Serialize, Deserialize)] | ||
| pub struct ThreadOwner { |
Collaborator
There was a problem hiding this comment.
let's include only existing features for now. we can add new features in followup PRs
pakrym-oai
reviewed
Apr 14, 2026
| /// Items to append in order. | ||
| pub items: Vec<RolloutItem>, | ||
| /// Optional idempotency key supplied by callers that may retry the same append. | ||
| pub idempotency_key: Option<String>, |
Collaborator
There was a problem hiding this comment.
is this actually used?
pakrym-oai
reviewed
Apr 14, 2026
| dynamic_tools, | ||
| memory_mode, | ||
| event_persistence_mode, | ||
| .. |
Collaborator
There was a problem hiding this comment.
surprised we are discarding a bunch of these fields
pakrym-oai
reviewed
Apr 14, 2026
| }) | ||
| } | ||
|
|
||
| async fn find_thread_by_name( |
wiltzius-openai
force-pushed
the
wiltzius/codex/thread-store-abstraction
branch
6 times, most recently
from
c9acf36 to
645e9e5
Compare
pakrym-oai
reviewed
Apr 14, 2026
| /// Working directory captured for the thread. | ||
| pub cwd: PathBuf, | ||
| /// Version of the CLI/app that created the thread. | ||
| pub cli_version: String, |
Collaborator
There was a problem hiding this comment.
this won't change in the scope of cli build
pakrym-oai
approved these changes
Apr 14, 2026
wiltzius-openai
force-pushed
the
wiltzius/codex/thread-store-abstraction
branch
from
645e9e5 to
4edef55
Compare
wiltzius-openai
force-pushed
the
wiltzius/codex/thread-store-abstraction
branch
from
4edef55 to
0c6fd51
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce a ThreadStore interface for mediating access to the filesystem (rollout jsonl files + sqlite db) based thread storage.
In later PRs we'll move the existing fs code behind a "local" implementation of this ThreadStore interface.
This PR should be a no-op behaviorally, it only introduces the interface.