Pass turn id with feedback uploads#17314
Conversation
bb7493f to
a3a85ac
Compare
There was a problem hiding this comment.
💡 Codex Review
codex/codex-rs/tui/src/chatwidget.rs
Lines 6474 to 6478 in a3a85ac
Update the production handle_server_notification path to store the current turn id. The ServerNotification::TurnStarted(_) arm ignores the payload, so last_turn_id is never set at runtime. open_feedback_note_editor then sends None, and feedback uploads miss the new turn_id tag despite this change’s intent. The only current assignment is in a #[cfg(test)] event path.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
841def8 to
9c8e71b
Compare
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
9c8e71b to
26461ec
Compare
|
/merge |
Summary
tagsdictionary to feedback upload params.tags.turn_idwith/feedbackuploads.thread_id,classification,cli_version,session_source, andreason.Behavior / impact
Existing feedback upload callers remain compatible because
tagsis optional and nullable. The wire shape is still a normal JSON object / TypeScript dictionary, so adding future feedback metadata will not require a new top-level protocol field each time. This change only adds feedback metadata for Codex CLI/TUI uploads; it does not affect existing pipelines, DAGs, exports, or downstream consumers unless they choose to read the newturn_idfeedback tag.Tests
cargo fmt -- --config imports_granularity=Itempassed; stable rustfmt warned thatimports_granularityis nightly-only.cargo run -p codex-app-server-protocol --bin write_schema_fixturescargo test -p codex-feedback upload_tags_include_client_tags_and_preserve_reserved_fieldscargo test -p codex-app-server-protocol schema_fixtures_match_generatedcargo test -p codex-tui build_feedback_upload_paramscargo test -p codex-tui live_app_server_turn_started_sets_feedback_turn_idcargo check -p codex-app-server --testsgit diff --check