feat(nx-dev): add angular landing page #31003
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
View your CI Pipeline Execution ↗ for commit bfd93de.
☁️ Nx Cloud last updated this comment at |
FrozenPandaz
added
the
priority: medium
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
| canonical: 'https://nx.dev/angular', | ||
| }, | ||
| openGraph: { | ||
| url: 'https://nx.dev/react', |
There was a problem hiding this comment.
The OpenGraph URL in the metadata is set to https://nx.dev/react, but since this is an Angular landing page, it should be https://nx.dev/angular to correctly represent the page's content. This ensures proper social sharing metadata when the page is linked on social platforms.
| url: 'https://nx.dev/react', | |
| url: 'https://nx.dev/angular', |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
| 'Add Nx to your Angular project for distributed task execution, intelligent caching, and affected commands.', | ||
| images: [ | ||
| { | ||
| url: 'https://nx.dev/socials/nx-react-media.png', |
There was a problem hiding this comment.
The OpenGraph image URL references nx-react-media.png but this is an Angular landing page. For consistency with the page's purpose, consider updating this to use an Angular-specific image (e.g., nx-angular-media.png).
| url: 'https://nx.dev/socials/nx-react-media.png', | |
| url: 'https://nx.dev/socials/nx-angular-media.png', |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
| Nx allows you to take existing React projects and add powerful | ||
| capabilities to your workflow. |
There was a problem hiding this comment.
The description text incorrectly references React projects instead of Angular projects. Since this is an Angular landing page, the text should be updated to: "Nx allows you to take existing Angular projects and add powerful capabilities to your workflow."
| Nx allows you to take existing React projects and add powerful | |
| capabilities to your workflow. | |
| Nx allows you to take existing Angular projects and add powerful | |
| capabilities to your workflow. |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
| /> | ||
| <FeatureCard | ||
| title="Zero Configuration" | ||
| j |
There was a problem hiding this comment.
There appears to be a stray character j on line 206 in the title prop of the FeatureCard component that should be removed. This is likely a typo that was accidentally introduced during development.
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
| Resources | ||
| </SectionHeading> | ||
| <p className="mt-4 text-lg text-slate-500 dark:text-slate-400"> | ||
| Learn more about using Nx with Java projects with these resources. |
There was a problem hiding this comment.
The text in the resources section incorrectly references "Java projects" when this is an Angular landing page. This should be updated to "Angular projects" to maintain consistency with the page's purpose and content.
| Learn more about using Nx with Java projects with these resources. | |
| Learn more about using Nx with Angular projects with these resources. |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
| sendCustomEvent( | ||
| 'nx-benefits-video-click', | ||
| 'nx-benefits-video', | ||
| 'react' |
There was a problem hiding this comment.
The analytics event parameter is set to 'react' but should be 'angular' since this component is for the Angular landing page. This would ensure accurate tracking of user interactions specific to the Angular page.
| 'react' | |
| 'angular' |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
| <ResourceCard | ||
| title="Gradle Tutorial" | ||
| description="Follow this step-by-step tutorial to add Nx to an existing Gradle project." | ||
| linkText="View tutorial" | ||
| href="/tutorials/gradle" | ||
| /> | ||
|
|
||
| <ResourceCard | ||
| title="Gradle Plugin Documentation" | ||
| description="Learn all the details about the Nx Gradle plugin configuration and usage." | ||
| linkText="View docs" | ||
| href="/packages/gradle/gradle-plugin" | ||
| /> |
There was a problem hiding this comment.
The resource cards in this section are referencing Gradle-related content (tutorials and documentation), but since this is an Angular landing page, these should be updated to point to Angular-specific resources instead. This would provide more relevant information to users visiting the Angular landing page.
| <ResourceCard | |
| title="Gradle Tutorial" | |
| description="Follow this step-by-step tutorial to add Nx to an existing Gradle project." | |
| linkText="View tutorial" | |
| href="/tutorials/gradle" | |
| /> | |
| <ResourceCard | |
| title="Gradle Plugin Documentation" | |
| description="Learn all the details about the Nx Gradle plugin configuration and usage." | |
| linkText="View docs" | |
| href="/packages/gradle/gradle-plugin" | |
| /> | |
| <ResourceCard | |
| title="Angular Tutorial" | |
| description="Follow this step-by-step tutorial to build Angular applications with Nx." | |
| linkText="View tutorial" | |
| href="/tutorials/angular" | |
| /> | |
| <ResourceCard | |
| title="Angular Plugin Documentation" | |
| description="Learn all the details about the Nx Angular plugin configuration and usage." | |
| linkText="View docs" | |
| href="/packages/angular" | |
| /> |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
| }, | ||
| }; | ||
|
|
||
| export default function ReactPage(): JSX.Element { |
There was a problem hiding this comment.
The function name ReactPage should be renamed to AngularPage to correctly reflect that this component renders the Angular landing page, not a React landing page. This would maintain consistency between the component's purpose and its name.
| export default function ReactPage(): JSX.Element { | |
| export default function AngularPage(): JSX.Element { |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
|
Closing this as no longer needed and may be using a different approach |
Add landing page for Nx and Angular. For use in promotional material.
Current Behavior
Expected Behavior
Related Issue(s)
Fixes #