Skip to content

Conversation

@panva
Copy link
Member

@panva panva commented Dec 11, 2025

#60850 updated a target that never runs with Debug builds, this broke the ability for CI to upload daily wpt.fyi reports

This PR reverts the test-wpt-report target to use NODE which is what CI consistently sets

Refs: https://openjs-foundation.slack.com/archives/C03BJP63CH0/p1765400746909869

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. labels Dec 11, 2025
@panva panva changed the title build: update test-wpt-report to use NODE instead OUT_NODE build: update test-wpt-report to use NODE instead of OUT_NODE Dec 11, 2025
@codecov
Copy link

codecov bot commented Dec 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.02%. Comparing base (e28656a) to head (2d99ee4).
⚠️ Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #61024      +/-   ##
==========================================
- Coverage   88.51%   88.02%   -0.50%     
==========================================
  Files         703      703              
  Lines      208496   208522      +26     
  Branches    40213    40128      -85     
==========================================
- Hits       184555   183548    -1007     
- Misses      15955    16935     +980     
- Partials     7986     8039      +53     

see 112 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@legendecas legendecas added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 12, 2025
@panva panva added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. request-ci Add this label to start a Jenkins CI on a PR.

6 participants