Skip to content

doc: add h1 summary to security release process#49112

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
RafaelGSS:doc/add-summary-to-security-release-process
Aug 17, 2023
Merged

doc: add h1 summary to security release process#49112
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
RafaelGSS:doc/add-summary-to-security-release-process

Conversation

@RafaelGSS
Copy link
Copy Markdown
Member

This has proven quite useful to either request disclosure on H1 and create the pos release announcement.

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/tsc
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Aug 11, 2023
Copy link
Copy Markdown
Member

@MoLow MoLow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Copy Markdown
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RafaelGSS RafaelGSS force-pushed the doc/add-summary-to-security-release-process branch from ba88713 to 97b946d Compare August 14, 2023 19:28
@RafaelGSS RafaelGSS added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 14, 2023
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Aug 14, 2023
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/49112
✔  Done loading data for nodejs/node/pull/49112
----------------------------------- PR info ------------------------------------
Title      doc: add h1 summary to security release process (#49112)
Author     Rafael Gonzaga  (@RafaelGSS)
Branch     RafaelGSS:doc/add-summary-to-security-release-process -> nodejs:main
Labels     doc
Commits    1
 - doc: add h1 summary to security release process
Committers 1
 - RafaelGSS 
PR-URL: https://github.com/nodejs/node/pull/49112
Reviewed-By: Moshe Atlow 
Reviewed-By: Matteo Collina 
Reviewed-By: Michael Dawson 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/49112
Reviewed-By: Moshe Atlow 
Reviewed-By: Matteo Collina 
Reviewed-By: Michael Dawson 
--------------------------------------------------------------------------------
   ⚠  Commits were pushed since the last approving review:
   ⚠  - doc: add h1 summary to security release process
   ℹ  This PR was created on Fri, 11 Aug 2023 21:13:42 GMT
   ✔  Approvals: 3
   ✔  - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/49112#pullrequestreview-1575388082
   ✔  - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/49112#pullrequestreview-1575728794
   ✔  - Michael Dawson (@mhdawson) (TSC): https://github.com/nodejs/node/pull/49112#pullrequestreview-1577361439
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/5861382314
@RafaelGSS RafaelGSS removed the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Aug 17, 2023
Copy link
Copy Markdown
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RafaelGSS RafaelGSS added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 17, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 17, 2023
@nodejs-github-bot nodejs-github-bot merged commit 3af6585 into nodejs:main Aug 17, 2023
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Landed in 3af6585

UlisesGascon pushed a commit that referenced this pull request Sep 10, 2023
PR-URL: #49112
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
@UlisesGascon UlisesGascon mentioned this pull request Sep 10, 2023
targos pushed a commit that referenced this pull request Nov 27, 2023
PR-URL: #49112
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
PR-URL: nodejs/node#49112
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
PR-URL: nodejs/node#49112
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Issues and PRs related to the documentations.

5 participants