Skip to content

[v14.x backport] doc: fix CJS-ESM selector in Safari#40561

Closed
aduh95 wants to merge 1 commit into
nodejs:v14.x-stagingfrom
aduh95:backport-safari-fix-to-v14
Closed

[v14.x backport] doc: fix CJS-ESM selector in Safari#40561
aduh95 wants to merge 1 commit into
nodejs:v14.x-stagingfrom
aduh95:backport-safari-fix-to-v14

Conversation

@aduh95
Copy link
Copy Markdown
Contributor

@aduh95 aduh95 commented Oct 22, 2021

Backport of #40135:

Safari needs a vendor prefix on the appearance of the checkbox

Screen Shot 2021-09-17 at 09 05 22

The original commit lands cleanly, I'm opening this to make sure this is backported, feel free to close this PR if it's not actually necessary.

Safari needs a vendor prefix on the appearance of the checkbox.

PR-URL: nodejs#40135
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. v14.x labels Oct 22, 2021
@aduh95 aduh95 changed the title doc: fix CJS-ESM selector in Safari [v14.x backport] doc: fix CJS-ESM selector in Safari Oct 22, 2021
targos pushed a commit that referenced this pull request Oct 31, 2021
Safari needs a vendor prefix on the appearance of the checkbox.

PR-URL: #40135
Backport-PR-URL: #40561
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@targos
Copy link
Copy Markdown
Member

targos commented Oct 31, 2021

Landed in adfc34c

@targos targos closed this Oct 31, 2021
@aduh95 aduh95 deleted the backport-safari-fix-to-v14 branch October 31, 2021 14:08
richardlau pushed a commit that referenced this pull request Nov 25, 2021
Safari needs a vendor prefix on the appearance of the checkbox.

PR-URL: #40135
Backport-PR-URL: #40561
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Issues and PRs related to the documentations.

4 participants