Skip to content

[v16.x backport] doc: format doc/api/*.md with markdown formatter #40530

Closed
Trott wants to merge 2 commits into
nodejs:v16.x-stagingfrom
Trott:backport-40403
Closed

[v16.x backport] doc: format doc/api/*.md with markdown formatter #40530
Trott wants to merge 2 commits into
nodejs:v16.x-stagingfrom
Trott:backport-40403

Conversation

@Trott
Copy link
Copy Markdown
Member

@Trott Trott commented Oct 20, 2021 •
edited
Loading

Backport of #40403. Current as of b83c938 in that PR. Backported from the landed commits so this is ready for review.
@Trott Trott requested a review from targos October 20, 2021 05:36
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. v16.x labels Oct 20, 2021
@Trott Trott mentioned this pull request Oct 20, 2021
Merged
Trott added 2 commits October 20, 2021 07:09
@Trott
test: adjust CLI flags test to ignore blank lines in doc
038121b 
PR-URL: nodejs#40403
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@Trott
doc: format doc/api/*.md with markdown formatter
ab54a10 
PR-URL: nodejs#40403
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@Trott
Copy link
Copy Markdown
Member Author

Trott commented Oct 20, 2021

Backported from the landed commits so this is ready for review.
@richardlau
Copy link
Copy Markdown
Member

richardlau commented Oct 20, 2021

I'd prefer to wait until after the 16 LTS transition before landing this.
@Trott Trott added the blocked PRs that are blocked by other issues or PRs. label Oct 20, 2021
@Trott
Copy link
Copy Markdown
Member Author

Trott commented Oct 20, 2021

Added blocked label that can be removed after 16.x is LTS.
@bnb
Copy link
Copy Markdown
Contributor

bnb commented Oct 20, 2021

yay! +1
@richardlau richardlau removed the blocked PRs that are blocked by other issues or PRs. label Oct 26, 2021
@targos
Copy link
Copy Markdown
Member

targos commented Nov 4, 2021

Landed in 6de88bc and 621266a
@targos targos closed this Nov 4, 2021
targos pushed a commit that referenced this pull request Nov 4, 2021
@Trott @targos
test: adjust CLI flags test to ignore blank lines in doc
6de88bc 
PR-URL: #40403
Backport-PR-URL: #40530
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos pushed a commit that referenced this pull request Nov 4, 2021
@Trott @targos
doc: format doc/api/*.md with markdown formatter
621266a 
PR-URL: #40403
Backport-PR-URL: #40530
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@Trott Trott deleted the backport-40403 branch November 4, 2021 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Issues and PRs related to the documentations.

5 participants

@Trott @richardlau @bnb @targos @nodejs-github-bot