lib,repl: ignore canBeRequiredByUsers built-in#39942
Closed
XadillaX wants to merge 1 commit into
Closed
Conversation
nodejs-github-bot
added
needs-ci
Contributor
|
Fixes: #39911 |
XadillaX
force-pushed
the
add-builin-libs-to-object
branch
from
f61ea9e to
032c4f2
Compare
aduh95
reviewed
Aug 30, 2021
aduh95
reviewed
Aug 30, 2021
XadillaX
force-pushed
the
add-builin-libs-to-object
branch
from
032c4f2 to
5a4a555
Compare
targos
reviewed
Aug 30, 2021
targos
reviewed
Aug 30, 2021
XadillaX
force-pushed
the
add-builin-libs-to-object
branch
from
5a4a555 to
47bccb6
Compare
tniessen
reviewed
Aug 30, 2021
Member
tniessen
left a comment
tniessen
left a comment
There was a problem hiding this comment.
This might need to be semver-major.
| }); | ||
|
|
||
| return promise; | ||
| } |
Member
There was a problem hiding this comment.
Most of this function seems to emulate what execFile does (promisified if a Promise is really necessary here).
XadillaX
force-pushed
the
add-builin-libs-to-object
branch
2 times, most recently
from
98a64ec to
0d07117
Compare
e.g. `wasi` under no `--experimental-wasi-unstable-preview1` flag shouldn't be pre-required.
XadillaX
force-pushed
the
add-builin-libs-to-object
branch
from
0d07117 to
a9ee4eb
Compare
Member
|
@tniessen I also wonder about the semverness. So far most things in the REPL were not considered semver-major if it did not change the public API. Since it's mostly experimental libraries, I would be fine to call it a fix while I would go with semver-major if anyone would argue for it. |
This comment has been minimized.
This comment has been minimized.
Lxxyx
approved these changes
Sep 1, 2021
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Collaborator
XadillaX
added a commit
that referenced
this pull request
Sep 7, 2021
e.g. `wasi` under no `--experimental-wasi-unstable-preview1` flag shouldn't be pre-required. PR-URL: #39942 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Contributor
Author
|
Landed in c7222b3 |
BethGriggs
pushed a commit
that referenced
this pull request
Sep 21, 2021
e.g. `wasi` under no `--experimental-wasi-unstable-preview1` flag shouldn't be pre-required. PR-URL: #39942 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
e.g.
wasiunder no--experimental-wasi-unstable-preview1flagshouldn't be pre-required.