tools: simplify eslint comma-dangle configuration (tools)#37883
Merged
Conversation
cjihrig
approved these changes
Mar 23, 2021
aduh95
approved these changes
Mar 24, 2021
marsonya
approved these changes
Mar 24, 2021
Remove the comma-dangle settings in tools/.eslintrc.yaml. They are duplicated in .eslintrc.js. PR-URL: nodejs#37883 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Member
Author
|
Landed in 32296fa |
ruyadorno
pushed a commit
that referenced
this pull request
Mar 29, 2021
Remove the comma-dangle settings in tools/.eslintrc.yaml. They are duplicated in .eslintrc.js. PR-URL: #37883 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
ruyadorno
pushed a commit
that referenced
this pull request
Mar 30, 2021
Remove the comma-dangle settings in tools/.eslintrc.yaml. They are duplicated in .eslintrc.js. PR-URL: #37883 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Merged
targos
pushed a commit
that referenced
this pull request
May 30, 2021
Remove the comma-dangle settings in tools/.eslintrc.yaml. They are duplicated in .eslintrc.js. PR-URL: #37883 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jun 5, 2021
Remove the comma-dangle settings in tools/.eslintrc.yaml. They are duplicated in .eslintrc.js. PR-URL: #37883 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jun 11, 2021
Remove the comma-dangle settings in tools/.eslintrc.yaml. They are duplicated in .eslintrc.js. PR-URL: #37883 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the comma-dangle settings in tools/.eslintrc.yaml. They are
duplicated in .eslintrc.js.