crypto: improve invalid arg type message for randomInt()#35089
Merged
Conversation
nodejs-github-bot
added
the
crypto
Collaborator
|
Review requested:
|
richardlau
approved these changes
Sep 7, 2020
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
request-ci
This comment has been minimized.
This comment has been minimized.
addaleax
approved these changes
Sep 8, 2020
Collaborator
lpinca
approved these changes
Sep 8, 2020
tniessen
approved these changes
Sep 8, 2020
Use "must be a safe integer" rather than "must be safe integer". I believe the former is more easily understood/clear. PR-URL: nodejs#35089 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Trott
force-pushed
the
a-safe-integer
branch
from
1f70a6d to
4063335
Compare
Member
Author
|
Landed in 4063335 |
ruyadorno
pushed a commit
that referenced
this pull request
Sep 17, 2020
Use "must be a safe integer" rather than "must be safe integer". I believe the former is more easily understood/clear. PR-URL: #35089 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
addaleax
pushed a commit
that referenced
this pull request
Sep 22, 2020
Use "must be a safe integer" rather than "must be safe integer". I believe the former is more easily understood/clear. PR-URL: #35089 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Merged
joesepi
pushed a commit
to joesepi/node
that referenced
this pull request
Jan 8, 2021
Use "must be a safe integer" rather than "must be safe integer". I believe the former is more easily understood/clear. PR-URL: nodejs#35089 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use "must be a safe integer" rather than "must be safe integer". I
believe the former is more easily understood/clear.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes