Skip to content

doc: add Triagers section to table of contents in GOVERNANCE.md#34504

Merged
Trott merged 2 commits into
nodejs:masterfrom
Trott:tri2
Jul 24, 2020
Merged

doc: add Triagers section to table of contents in GOVERNANCE.md#34504
Trott merged 2 commits into
nodejs:masterfrom
Trott:tri2

Conversation

@Trott
Copy link
Copy Markdown
Member

@Trott Trott commented Jul 24, 2020

Checklist
@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Jul 24, 2020
@targos
Copy link
Copy Markdown
Member

targos commented Jul 24, 2020

Fast-track ?
@targos targos added the fast-track PRs that do not need to wait for 72 hours to land. label Jul 24, 2020
Gabriel Schulhof and others added 2 commits July 23, 2020 23:28
n-api: run all finalizers via SetImmediate()
a74a6e3 
Throwing an exception from a finalizer can cause the following fatal
error:

Error: async hook stack has become corrupted (actual: 2, expected: 0)
 1: 0x970b5a node::InternalCallbackScope::~InternalCallbackScope()
    [./node]
 2: 0x99dda0 node::Environment::RunTimers(uv_timer_s*) [./node]
 3: 0x13d8b22  [./node]
 4: 0x13dbe42 uv_run [./node]
 5: 0xa57974 node::NodeMainInstance::Run() [./node]
 6: 0x9dbc17 node::Start(int, char**) [./node]
 7: 0x7f4965417f43 __libc_start_main [/lib64/libc.so.6]
 8: 0x96f4ae _start [./node]

By nodejs#34341 (comment),
calling into JS from a finalizer and/or throwing exceptions from there
is not advised, because the stack may or may not be set up for JS
execution. The best solution is to run the user's finalizer from a
`SetImmediate()` callback.

Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com>
Fixes: nodejs#34341
PR-URL: nodejs#34386
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
@Trott
doc: add Triagers section to table of contents in GOVERNANCE.md
001a4a7 
PR-URL: nodejs#34504
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
@Trott
Copy link
Copy Markdown
Member Author

Trott commented Jul 24, 2020

Landed in 001a4a7
@Trott Trott merged commit 001a4a7 into nodejs:master Jul 24, 2020
@Trott Trott deleted the tri2 branch July 24, 2020 14:25
MylesBorins pushed a commit that referenced this pull request Jul 27, 2020
@Trott @MylesBorins
doc: add Triagers section to table of contents in GOVERNANCE.md
2297d74 
PR-URL: #34504
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
@ruyadorno ruyadorno mentioned this pull request Jul 28, 2020
Merged
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@Trott @addaleax
doc: add Triagers section to table of contents in GOVERNANCE.md
4cb6c6c 
PR-URL: #34504
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@Trott @addaleax
doc: add Triagers section to table of contents in GOVERNANCE.md
cef1284 
PR-URL: #34504
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
@codebytere codebytere mentioned this pull request Sep 28, 2020
Merged
@mhdawson mhdawson mentioned this pull request Jan 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fast-track PRs that do not need to wait for 72 hours to land. meta Issues and PRs related to the general management of the project.

5 participants

@Trott @targos @gireeshpunathil @HarshithaKP @nodejs-github-bot